-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: quick freeze/unfreeze utxos #591
Conversation
wip: still work-in-progress; icons needs to be updated
7871cb1
to
cf6f78c
Compare
Q: In order to save some space on mobile devices, should the "quick freeze/unfreeze" button move from it's own column to the position of the "utxo icon" when hovering the row? ping @editwentyone |
@theborakompanioni because there is no hover mode on mobile, we don't need the column with the action icon. we just need the status column with the snowflake. if a user wants to perform an action, he needs to select the row and unveil the action buttons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like it.
It feels a little unintuitive to me, as I would expect the "freeze" action icon to be the same as the freeze indicator icon, as it is the case with "like" or "favorite" and so on. (Compare with "star" in Gmail's list view, or "read/unread" in ProtonMail's list view, and so on.)
Having a 2nd icon for the action is a bit weird, and having a one column for the state (frozen, not frozen) and one column for the action (freeze, unfreeze) is also unusual. Apologies on my side for bringing this up now, and not earlier in Figma.
That being said, it's a small feature for power-users, and it's good as it is. Tested on desktop and mobile. Let's see what the users say, if anything.
Looks good to me, tACK ✅
Closes #480.
Closes #525.
This PR introduces a way to quickly freeze or unfreeze single UTXOs.
Some decision have been made that differ from the Figma design:
📸 Before/After
Mobile